fix: propagate SIGINT exit status on POSIX#586
Open
lawrence3699 wants to merge 1 commit intoopen-cli-tools:mainfrom
Open
fix: propagate SIGINT exit status on POSIX#586lawrence3699 wants to merge 1 commit intoopen-cli-tools:mainfrom
lawrence3699 wants to merge 1 commit intoopen-cli-tools:mainfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #470
When
concurrentlyitself receivesSIGINTon POSIX, it currently exits with code0after shutting down its children. That makes shell callers treat Ctrl+C as success, so&&chains continue running.This keeps the existing shutdown flow for child commands, but once the run finishes it re-sends
SIGINTto theconcurrentlyprocess on POSIX so the parent shell observes an interrupted command instead of a successful exit. Windows behavior stays unchanged.Validation:
pnpm buildpnpm test -- --run bin/index.spec.ts -t 'propagates SIGINT on POSIX when interrupted'bash -lc 'node dist/bin/index.js "exec sleep 1000" "exec sleep 2000" && echo STILL_HERE'and aSIGINTsent to the process group: before the patch it printedSTILL_HERE, after the patch it exited withSIGINTand did not print it